Excerpt - Incorrect Total Checks

select  dso.object_id, dso.object_name, dso.object_full_name 
  from DSS_OBJECTS dso
  join ( select R.SNAPSHOT_ID,
                        R.OBJECT_ID,
                        count(distinct DLIM.PREVIOUS_OBJECT_ID) as SHARING_FACTOR,
                        count(distinct DLI.PREVIOUS_OBJECT_ID) as T_SHARING_FACTOR
        from DSS_METRIC_TYPES T
        join DSS_METRIC_HISTO_TREE HT
          on HT.METRIC_ID = T.METRIC_ID
         and T.METRIC_GROUP = 1
    --     and HT.METRIC_CRITICAL = 1
        join DSS_METRIC_RESULTS R
          on R.METRIC_ID = HT.METRIC_ID + 1
         and R.METRIC_VALUE_INDEX = 1
         and R.SNAPSHOT_ID = HT.SNAPSHOT_ID 
         join DSS_LINK_INFO DLI
           on DLI.SNAPSHOT_ID = HT.SNAPSHOT_ID 
          and DLI.LINK_TYPE_ID = 3
          and DLI.NEXT_OBJECT_ID = R.OBJECT_ID
         join DSS_LINK_INFO DLIM
           on DLIM.SNAPSHOT_ID = HT.SNAPSHOT_ID 
          and DLIM.LINK_TYPE_ID = 1
          and DLIM.NEXT_OBJECT_ID = DLI.PREVIOUS_OBJECT_ID
         join DSS_OBJECTS dsom
           on dsom.OBJECT_ID = dlim.PREVIOUS_OBJECT_ID
          and dsom.OBJECT_TYPE_ID = 20000
          and dsom.OBJECT_NAME not like '%union_content%'
         join DSS_OBJECTS dsot
           on dsot.OBJECT_ID = dli.PREVIOUS_OBJECT_ID
        where R.SNAPSHOT_ID = <Snapshot_id>
                  and T.METRIC_Id = <Metric_id>
        group by R.SNAPSHOT_ID, R.OBJECT_ID
                ) T
    on T.OBJECT_ID = dso.OBJECT_ID 
 where     T.SHARING_FACTOR > 1        
 or T.T_SHARING_FACTOR > 1

CREATE OR REPLACE FUNCTION DIAG_ABAP_ANA_ARTIF_T_TOTAL
                                                        (
                                                                I_SNAPSHOT_ID IN                                              INT,
                                                                               - the metric SNAPSHOT id I_METRIC_PARENT_ID IN INT,
                                                                               - the metric parent id I_METRIC_ID IN          INT,
                                                                               - the metric id I_METRIC_VALUE_INDEX IN        INT
                                                        )
        RETURN INT
IS
        ERRORCODE INT := 0;
BEGIN
        --<<NAME>>DIAG_ABAP_ANA_ARTIF_T_TOTAL<</NAME>>*/
        --<<COMMENT>> Template name = DSSGENERICTOTAL. <</COMMENT>>
        --<<COMMENT>> Definition = Number of ABAP Artifacts with OpenSQL queries. <</COMMENT>>
        INSERT
        INTO   DSS_METRIC_RESULTS
               (
                      METRIC_NUM_VALUE  ,
                      METRIC_OBJECT_ID  ,
                      OBJECT_ID         ,
                      METRIC_ID         ,
                      METRIC_VALUE_INDEX,
                      SNAPSHOT_ID
               )
        SELECT   COUNT( T1.OBJECT_ID),
                 0                   ,
                 SC.OBJECT_PARENT_ID ,
                 I_METRIC_ID         ,
                 I_METRIC_VALUE_INDEX,
                 I_SNAPSHOT_ID
        FROM     ObjInf T2          ,
                 DSSAPP_ARTIFACTS T1,
                 DSSAPP_MODULES MO  ,
                 DSS_METRIC_SCOPES SC
        WHERE    SC.SNAPSHOT_ID      = I_SNAPSHOT_ID
        AND      SC.METRIC_PARENT_ID = I_METRIC_PARENT_ID
        AND      SC.METRIC_ID        = I_METRIC_ID
        AND      SC.COMPUTE_VALUE    = 0
        AND      MO.TECHNO_TYPE      = -15 - Technologic ABAP object
        AND      MO.MODULE_ID        = SC.OBJECT_ID
        AND      T1.APPLICATION_ID   = SC.OBJECT_ID
        AND      NOT EXISTS
                 ( SELECT 1
                 FROM    DSS_OBJECT_EXCEPTIONS E
                 WHERE   E.METRIC_ID = I_METRIC_ID
                 AND     E.OBJECT_ID = T1.OBJECT_ID
                 )
                 - OPEN SQL
        AND      T1.OBJECT_ID = T2.IdObj
        AND      T2.InfTyp    = 9
        AND      T2.InfSubTyp = 1538
        AND      T2.InfVal    > 0
        GROUP BY SC.OBJECT_PARENT_ID,
                 SC.OBJECT_ID ;
        
        RETURN ERRORCODE;
END DIAG_ABAP_ANA_ARTIF_T_TOTAL;