CAST Engineering Dashboard - Violations - False Violation on Documentation - V2

CAST Engineering Dashboard - Violations - False Violation - Avoid Artifacts with high Commented-out Code Lines per Code Lines ratio may appear as a new violation

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

This page provides information on the metric “Avoid Artifacts with high Commented-out Code Lines/Code Lines ratio”, which may appear as a new violation in a dashboard when there is no change in a particular file.

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Details

You can get new violations for the rule “Avoid Artifact with high Commented-out Code Lines/Code Lines ratio” even when there has been no code change for a particular file.

CAST Engineering Dashboard - Violations - False Violation - Avoid Artifacts with High Depth of Code

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

Violation for quality rule ‘Avoid Artifacts with High Depth of Code’ seems to be not correct

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Action Plan

Although the source code seems to have only 2 levels of if/else and no loops,

Check the source code not for levels of nesting but for the branches. This Quality rule is not dependent on levels but on the control flow.
1. In the code check if there are more than 5 branches to if/else.

Notes/comments

CAST Engineering Dashboard - Violations - False Violation - Avoid Classes with a High Number Of Children

Mon, 01 Jan 0001 00:00:00 +0000

Purpose (problem description)

This page handle the issue of false violation for the Quality rule “Avoid Classes with a High Number Of Children”

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step scenario

Compute snapshot
Open CED
Observe that the violation “Avoid Classes with a High Number Of Children” is a false one

Action Plan

Perform the below actions

Check if the number of children computed in the KB is correct -
Run the below query on Knowledge Base -

CAST Engineering Dashboard - Violations - False Violation - Avoid Classes with a High Public Data Ratio

Mon, 01 Jan 0001 00:00:00 +0000

Purpose (problem description)

This page handle the issue of false violation for the Quality rule “Avoid Classes with a High Public Data Ratio”

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step scenario

Compute snapshot
Open CED
Observe that the violation “Avoid Classes with a High Public Data Ratio” is a false one

Action Plan

Perform the below actions

Check if the number of fields and public fields is correctly computed in the KB, the 2 parameters are computed correctly if there values are equal to the values from the source code, for example, if an object from the source code have 1 public field and 1 private field then “num_fields” should be equal to 2 and “num_pub_field” should be equal to 1:

CAST Engineering Dashboard - Violations - False Violation - Avoid cyclical calls

Mon, 01 Jan 0001 00:00:00 +0000

Action Plan

The page gives ways to validate the cycle reported by ‘Avoid cyclical call’.

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Details

Apply instructions given in one of the following pages:

Enlighten - Information - How to identify cyclical calls when Escalated links are activated

Enlighten - Information - How to Identify cyclical calls when Escalated links are not activated

Notes/comments

CAST Engineering Dashboard - Violations - False Violation - Avoid directly instantiating a Class used as a Spring bean

Mon, 01 Jan 0001 00:00:00 +0000

Description

When using explicit object constructors ((i.e. new ), you get violations for the quality rule “Avoid directly instantiating a Class used as a Spring bean”.

The goal of the quality rule “Avoid directly instantiating a Class used as a Spring bean” is to check for proper use of beans initialization and use.

The goal of beans in an application, is to provide a framework, to build objects and to set properties according to the configuration file.

CAST Engineering Dashboard - Violations - False Violation - Avoid disabling source code inspection

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

Violation for quality rule ‘Avoid disabling source code inspection’ seems to be not correct. Though there are no check on/check off in the object, yet the object is seen under list of violated objects.

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Details

Here an example of a scenario in which the violation is expected:

The object f_recherche_anlage of object type - ABAP Form is under violation. f_recherche_anlage is calling the object mac_message of object type - ABAP Macro Though there are no check on/check off in the f_recherche_anlage, there are check on/check off in mac_message yet macro is not violated.

CAST Engineering Dashboard - Violations - False Violation - Avoid empty catch blocks

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

Dashboard shows false violation for Metric “Avoid empty catch blocks”.

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Details

Possible reasons

For SAP/ABAP:

Case 1 artifact has no ‘catch’ block in the code but is reported as violationg the quality rule: looking at the right tab

Source code violation highlights over two part Declaration and Implementation.

For the default view , you can only see Declaration part highlighted (In Red) which may not contain CATCH Block,

CAST Engineering Dashboard - Violations - False Violation - Avoid indirect String concatenation inside loops QR

Mon, 01 Jan 0001 00:00:00 +0000

Description

This would guide to understand in depth about the metric and how to debug the violations for the metric Avoid indirect String concatenation inside loops

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Action Plan

The metric Avoid indirect String concatenation inside loops search for the contents of methods used in loops that will have string concatenation in them.

See the implementation of the method for which it is violated and also the methods called.
1. For example in the below violation you also need to see the implementation of the method setRequiredInfo which might have the string concatenation.

Impact on Analysis Results and Dashboard

CAST Engineering Dashboard - Violations - False Violation - Avoid Programs with lines of more than 80 characters

Mon, 01 Jan 0001 00:00:00 +0000

Description

This page provides the details about the wrong violations that are flagged for the Quality Rule “Avoid Programs with lines of more than 80 characters” on the dashboard.

Please see the below screenshot for clarity:

The violations are flagged even after configuring the option of free-format code in the CAST Management Studio, as shown below:

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step Scenario

CAST Engineering Dashboard - Violations - False Violation - Avoid SQL queries with implicit conversions in the WHERE clause

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

Violation for quality rule ‘Avoid SQL queries with implicit conversions in the WHERE clause’ seems to be not correct

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Details

You are not expecting a violation for this rule since the source code does not seem to contain implicit conversions in the where clause.

If the code looks like below :

Select T.id 
from Table T 
where T.name = 'example_name';

T.name = ’example_name’ is seen as an implicit conversion from CHAR to VARCHAR ,’example_name’ is identified with a CHAR, provided name is declared as VARCHAR.

CAST Engineering Dashboard - Violations - False Violation - Avoid Stored Procedures not returning a status value

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

Violation for quality rule ‘Avoid Stored Procedures not returning a status value’ seems to be not correct

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Details

The issue is that the last parameter is of Output type, hence, no status value could be returned for the stored procedures.

But for this rule we look for explicit return values (as not returning a status value can lead to data corruption and incorrect behavior). Using parameter type as OUTPUT to return values to the caller of the procedure is a valid scenario too. However,

CAST Engineering Dashboard - Violations - False Violation - Avoid Subroutines with a very low comment code ratio RPG300

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

Violation for quality rule ’ Avoid Subroutines with a very low comment/code ratio (RPG300)’ seems to be not correct.

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Details

By seeing the below screenshot you can assume that AA05_FIRST has 7 comment lines but there is only one comment which is highlighted in yellow**,** rest are blank comments (C* are not considered as comments as these are blank) which analyzer doesn’t treat as comment. Also note that only inner comment lines are considered while calculating the comment/code ratio & the threshold value of Comment/code ratio is 10 i.e. if the ratio is less than this value it will violate otherwise not and in this case the subroutine has comment/code ratio less than 10, so the violation is correct.

CAST Engineering Dashboard - Violations - False Violation - Avoid too many copy pasted artifacts

Mon, 01 Jan 0001 00:00:00 +0000

Purpose (problem description)

This page handle the case when an object is not supposed to be violated by the QR “Avoid too many copy pasted artifacts”, but the violation is missing

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step scenario

Take snapshot
Open CED and observe that the violation is missing

Action Plan

Perform the below actions

From the knowledge schema, get the Id of the artifact that is similar to the object on which there is violation:

CAST Engineering Dashboard - Violations - False Violation - Avoid types that own disposable fields and are not disposable

Mon, 01 Jan 0001 00:00:00 +0000

Description

This page provides the details on wrong violations that are flagged for the Quality Rule “Avoid types that own disposable fields and are not disposable” on the dashboard.

Please refer to the screenshots below showing the issue:

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step Scenario

Below is the step-by-step scenario leading to the problem:

Package and deliver the source code with .NET assemblies.

CAST Engineering Dashboard - Violations - False Violation - Avoid unreferenced PHP Files - PHP

Mon, 01 Jan 0001 00:00:00 +0000

Description

Consider three PHP files A.php*,*B.php and C.php . A.php contains a class namely “ClassA” which is instantiated in files “B.php” and “C.php”. Considering this as reference between the files ; violation of metric Avoid unreferenced PHP Files (PHP) is false violation.

This is not a false violation.

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Details

In PHP, if one wants to initialize a class (in this case ClassA), which is defined in other file (in this case A.php), one should include/require that file in the target file (in this case B.php/C.php).

CAST Engineering Dashboard - Violations - False Violation - Avoid Unused Imports

Mon, 01 Jan 0001 00:00:00 +0000

Description

This page provides the details and the solution for the issue of false violations that are flagged for the Quality Rule “Avoid Unused Imports” on the dashboard.

Refer to the below screenshot for more clarity about the issue:

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step Scenario

Below is the step-by-step scenario leading to the problem:

Ran analysis and snapshot.
Searched for avoid unused import in dashboard.
False indications for “Avoid Unused Imports” metric.

Impact of the Problem

CAST Engineering Dashboard - Violations - False Violation - Avoid using deprecated objects

Mon, 01 Jan 0001 00:00:00 +0000

Purpose (problem description)

This page provides information on the violation raised for the rule-“Avoid using deprecated objects” on Oracle connection objects:

Observed in CAST Version

Release	Yes/No
8.3	✅

Observed in JEE Extension version

Release	Yes/No
>=1.0.x	✅

Observed in RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step scenario

Run analysis+snapshot
Launch Dashboard
Observe violation for rule- “Avoid using deprecated objects” on Oracle connection objects

Action Plan

If you observe the violations raised for the rule- “Avoid using deprecated objects” on Oracle connection objects then please note the below points:

CAST Engineering Dashboard - Violations - False Violation - Avoid using the scanf function family

Mon, 01 Jan 0001 00:00:00 +0000

Description

This page provides the solution to a known problem of wrong violation which is flagged for the Quality Rule “Avoid using the scanf() function family” because the documentation of the Quality Rule is having incorrect remediation.

Below is a screenshot of the issue which shows the violation on the dashboard:

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step Scenario

CAST Engineering Dashboard - Violations - False Violation - Check usage of equal equal and not equal on objects

Mon, 01 Jan 0001 00:00:00 +0000

Description

This page provides the details on wrong violations that are flagged for the Quality Rule “Check usage of ‘==’ and ‘!=’ on objects”.

Please refer to the below screenshot:

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step Scenario

Below is the step-by-step scenario leading to the problem:

Run analysis + snapshot for a JAVA application.
Open dashboard and login.
Check the violations for QR - Check usage of ‘==’ and ‘!=’ on objects.

Impact of the Problem

CAST Engineering Dashboard - Violations - False Violation - Close database resources ASAP

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

This page provides information about the quality rule - Close database resources ASAP.

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Details

If you have closed the open connections using a method call containing the connection.close then it is expected to have this as violation though it may seem that the connection is closed for you.

Example -

public static void main(String [] args) {
 Connection con = null;
 com.mysql.jdbc.jdbc2.optional.MysqlDataSource datasource1 = new com.mysql.jdbc.jdbc2.optional.MysqlDataSource();
 con = datasource1.getConnection();
 
 close_connections(con);
}
 
public static void close_connections(Connection con1) {
 con1.close();
}

The analyzer is designed in such a way to violate such code as the method close_connections which is calling the close connection may change and then you will not be sure that the connection is actually closed. This is not a good programming practice and the connection.close(); should appear in the same block. So this is expected behavior to have the violation.

CAST Engineering Dashboard - Violations - False Violation - Close the outermost stream ASAP

Mon, 01 Jan 0001 00:00:00 +0000

Description

You are getting a violation that seems wrong for you for quality rule - Close the outermost stream ASAP .

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step Scenario

Taking analysis and snapshot
Observing a violation for ‘Close the outermost stream ASAP’ that seems to be wrong

Action Plan

Check if you have closed the outermost stream both in the try block and in the finally block as shown in below source code.
Example -

CAST Engineering Dashboard - Violations - False Violation - Control naming convention - prefix case and character set control

Mon, 01 Jan 0001 00:00:00 +0000

Purpose (problem description)

This page troubleshoot the issues you encounter with the violation on the quality rule “Control naming convention - prefix, case and character set control”.

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step scenario

Run analysis
Take a snapshot

Action Plan

To troubleshoot this issue, you need the following Relevant input

Check if you are using the Cast naming convention. Control naming convention should respect naming conventions described in the following official page: Controls naming convention - prefix, case and character set control
If not, then it’s normal to have a violation but you can Use other convention
1. If you are using other conventions that does not follow the default naming convention of CAST, then you can parameter this by following steps described in the following page CAST Management Studio - Information - How to customize the quality rule control naming convention - prefix case and character set control
CAST Management Studio CMS - Information - How to customize the quality rule Control naming convention - prefix, case and character set control
If not then contact Technical Support CAST Technical Support with Relevant input

Relevant input

Screenshots with URL visible, showing the violation rule and the violated object
CAST Support Tool (CST) - alias Sherlock

Notes/comments

CAST Engineering Dashboard - Violations - False Violation - DOTNet - Data access must be based on Stored Procedure Calls

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

Object is not (or is wrongly) detected as a violation of this Quality Rule.

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Details

This wrong violation is due to a wrong call link from a C# method or a VB method to a SQL Table.

To solve this wrong link problem, please refer to Special Cases, for Dot NET in CMS Snapshot Analysis - Run Analyzer - Missing or Wrong links between two objects

CAST Engineering Dashboard - Violations - False Violation - EGL - Avoid Program calls without checking the return code EGL

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

Object is not (or is wrongly) detected as a violation of this QR.

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Action Plan

Check if the return code check is done through an implicit call inside a function. Below is an example of subfunction - where return check is implemented - is called inside the mainfunction :

Currently (EGL package 1.0.2), CAST does not consider the implicit calls . So it will be a violation. The rule is based on a grep on the function call pattern and CAST do not check inside the subfunction.

CAST Engineering Dashboard - Violations - False Violation - File descriptor block must be defined with 0 record

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

Object is not (or is wrongly) detected as a violation of this QR.

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Details

It actually can be a normal behaviour due to the below findings; If there is a dot (’.’) just after the first clause of the FD and before the end of the sentence (see the sample code below).

This makes the FD reduced to the first clause and then there is no BLOCK CONTAINS clause identified by the analyzer raising violations for this metric even if we have the BLOCK SIZE declared.This is actually normal behavior since this is not correct code to have a dot (’.’) followed by the first clause of the FD.So it is advisable to remove the dot (’.’) to correct the code and remove these violations.

CAST Engineering Dashboard - Violations - False Violation - Mainframe - COBOL - Each opened file must be closed

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

Object is not (or is wrongly) detected as a violation of this QR.

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Action Plan

Check the analysis configuration to see if the default option “Read Terminal Format” is set to true. If yes, then it will trigger false violation for this particular diag.
Check the option “end column no comment” In order to avoid getting such violations. It allows the source code to be located after column 72

By default this option is unselected, however, when selected, the analyzer/reference finder will assume that all information included beyond column 72 is code and will process it when the job is run.

CAST Engineering Dashboard - Violations - False Violation - Methods must have appropriate JavaDoc exception tags

Mon, 01 Jan 0001 00:00:00 +0000

Problem

On the dashboard, you observe violations on Methods must have appropriate JavaDoc @exception tags quality rule . The violations seems to be wrong violations

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step Scenario

Do and analysis and snapshot
Connect to dashboard and observe violations on Methods must have appropriate JavaDoc @exception tags quality rule that seems to be wrong violations

Action Plan

CAST Engineering Dashboard - Violations - False Violation - Methods must have appropriate JavaDoc param tags QR

Mon, 01 Jan 0001 00:00:00 +0000

Description

“Methods must have appropriate JavaDoc @param tags” is violated if the description to the parameter is not provided.

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step Scenario

Check if all the @param tags has the parameter name and description.
The @param [parameterName] [Description]

Action Plan

Add the description to all the parameter tags.

CAST Engineering Dashboard - Violations - False Violation - Methods must have appropriate JavaDoc throws tags

Mon, 01 Jan 0001 00:00:00 +0000

Description

On the dashboard, you observe the violations on Methods must have appropriate JavaDoc @throws tags quality rule . The violations seems to be wrong violations

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step Scenario

Do and analysis and snapshot
Connect to dashboard and observe violations on Methods must have appropriate JavaDoc @throws tags quality rule which seems to be wrong violations

Action Plan

CAST Engineering Dashboard - Violations - False Violation - New violations showing up for unchanged code

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

This page provides information on new violations showing up for Architecture Checker rules for unchanged code.

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Action Plan

In certain circumstances, you may see new Architecture Checker violations on unchanged code.

Case 1: New Dynamic Links cause layer violations

One case is when you may have a new dynamic link, which you may not have expected that violates the Architecture layer rules that you have set up.

CAST Engineering Dashboard - Violations - False Violation - Object violations from Vanilla

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

You are seeing Object Violations from Vanilla on the Engineering Dashboard when you are only expecting to see objects from the project.

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Action Plan

It is expected to get some vanilla objects displayed on the dashboard for modules REPOSITORY_MODIFIED and _MODIFIED.

Indeed, here is the definition of every module:

Repository_Added are all objects that are added in your repository compared to what is in the standard vanilla analyzed .
Repository_modified are objects from the vanilla that have been modified in the Repository.
_added are all objects that are added in your application compared to what is in the standard vanilla analyzed (that is a subset of Repository_Added),
_modified are objects from the vanilla that have been modified in the application (that is a subset of Repository_modified).

The Repository_modified is listing all the violations of objects from vanilla that have been modified in the repository (when compared to the standard). Please note that the violations given can be already present in the standard object and not due to the modification done. The Siebel package is not able to distinguish between violations already present in the standard object and the one created by the modification done.

CAST Engineering Dashboard - Violations - False Violation - Provide a private default Constructor for utility Classes

Mon, 01 Jan 0001 00:00:00 +0000

Description

This page details the case of false violation for quality rule “Provide a private default Constructor for utility Classes”.

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step Scenario

Login to CED.
Go to Investigation Quality Model Drill down View.
Click on the rule name - Provide a private default Constructor for utility Classes.

Details

In the example mentioned in the below screenshot you can see that there are a mixture of static and non-static methods in the class.

CAST Engineering Dashboard - Violations - False Violation - Siebel - Wrong violations for Quality rules referring to the Sort or Search on non-indexed Fields

Mon, 01 Jan 0001 00:00:00 +0000

Purpose (problem description)

This page handles the case when you are getting large number of false violations for Quality rules referring to the Sort or Search on non-indexed Fields. The Quality rules are the following:

Avoid BusComp using Sort specifications on non-indexed Fields
Avoid PickList using Sort specifications on non-indexed Fields
Avoid Link using Sort specifications on non-indexed Fields
Avoid BusComp using Search specifications on non-indexed Fields
Avoid PickList using Search specifications on non-indexed Fields
Avoid Link using Search specifications on non-indexed Fields
Avoid Applet using Search specifications on non-indexed Fields

Observed in CAST AIP

CAST Engineering Dashboard - Violations - False Violation - Standard packages are flagged as violated

Mon, 01 Jan 0001 00:00:00 +0000

Description

This page describes the case when a standard package is flagged for a violation when it is not supposed to be.

The following example shows that objects java.* are violated by the QR “Avoid cyclical calls and inheritances” while the objects are standard packages which should not be violated.

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step Scenario

CAST Engineering Dashboard - Violations - False Violation - Track Classes referencing database objects

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

To explain the purpose of the metric

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Details

The metric " Track Classes referencing database objects " will list all of the classes which has the access to the database as usually the complete application will have access to the database.

This is not the violation on the class. Once you verify that the class has the valid connections to database you can add the class to the exclusion list of metric to not show this on the dashboard.

CAST Engineering Dashboard - Violations - False Violation - Use of Style sheets

Mon, 01 Jan 0001 00:00:00 +0000

Description

This page provides the details on wrong violations that are flagged for the Quality Rule “Use of Style sheets” on the dashboard even when the source code has CSS (Cascading Style Sheets) referenced.

Please refer to the below screenshots showing the issue:

Observed in CAST AIP

Release	Yes/No
8.3.x	✅

Observed on RDBMS

RDBMS	Yes/No
CSS	✅

Step by Step Scenario

Below is the step-by-step scenario leading to the problem:

CAST Engineering Dashboard - Violations - False Violation - Wrong violations added when the 2 snapshots are not computed with same CAST version

Mon, 01 Jan 0001 00:00:00 +0000

Purpose

Object is not (or is wrongly) detected by the QR detail procedure where it was (was not) in previous snapshot.

Applicable in CAST Version

Release	Yes/No
8.3.x	✅

Applicable RDBMS

RDBMS	Yes/No
CSS	✅

Details

Check if the used detail procedures have been modified between these 2 snapshots. This is particularly relevant when the 2 snapshots are not computed with same CAST version: A migration has been performed between the 2 snapshots computation for example. You can check the section Functional information > Changes in the metrics and diagnostics results
If you cannot identify any relevant modification in the used detail procedure or if the 2 snapshot are computed with same CAST version, you need just to proceed as described above to investigate issue
If the issue could not be reproduced on the Fresh KB and the issue is reproduced using customer KB (without analysis), then this issue could be related to the remaining objects from the previous analysis. In this case, ask the customer to drop the results from KB and re-analyze & re-generate the snapshots. e.g. in webcall 22517, object was listed in high risk objects for “Avoid using untyped dataset”, when there was no source code related to the dataset in the source code. So this object was present in the KB from the previous analysis (PLEASE NOTE THAT DROPPING ANALYSIS RESULTS WILL LEAD TO ADDED DELETED OBJECTS).

Notes/comments

CAST Engineering Dashboard - Violations - False Violation on Documentation - V2

CAST Engineering Dashboard - Violations - False Violation - Avoid Artifacts with high Commented-out Code Lines per Code Lines ratio may appear as a new violation

CAST Engineering Dashboard - Violations - False Violation - Avoid Artifacts with High Depth of Code

CAST Engineering Dashboard - Violations - False Violation - Avoid Classes with a High Number Of Children

Step by Step scenario

CAST Engineering Dashboard - Violations - False Violation - Avoid Classes with a High Public Data Ratio

Step by Step scenario

CAST Engineering Dashboard - Violations - False Violation - Avoid cyclical calls

CAST Engineering Dashboard - Violations - False Violation - Avoid directly instantiating a Class used as a Spring bean

CAST Engineering Dashboard - Violations - False Violation - Avoid disabling source code inspection

CAST Engineering Dashboard - Violations - False Violation - Avoid empty catch blocks

Possible reasons

For SAP/ABAP:

Case 1 artifact has no ‘catch’ block in the code but is reported as violationg the quality rule: looking at the right tab

CAST Engineering Dashboard - Violations - False Violation - Avoid indirect String concatenation inside loops QR

CAST Engineering Dashboard - Violations - False Violation - Avoid Programs with lines of more than 80 characters

CAST Engineering Dashboard - Violations - False Violation - Avoid SQL queries with implicit conversions in the WHERE clause

CAST Engineering Dashboard - Violations - False Violation - Avoid Stored Procedures not returning a status value

CAST Engineering Dashboard - Violations - False Violation - Avoid Subroutines with a very low comment code ratio RPG300

CAST Engineering Dashboard - Violations - False Violation - Avoid too many copy pasted artifacts

Step by Step scenario

CAST Engineering Dashboard - Violations - False Violation - Avoid types that own disposable fields and are not disposable

CAST Engineering Dashboard - Violations - False Violation - Avoid unreferenced PHP Files - PHP

CAST Engineering Dashboard - Violations - False Violation - Avoid Unused Imports

CAST Engineering Dashboard - Violations - False Violation - Avoid using deprecated objects

CAST Engineering Dashboard - Violations - False Violation - Avoid using the scanf function family

CAST Engineering Dashboard - Violations - False Violation - Check usage of equal equal and not equal on objects

CAST Engineering Dashboard - Violations - False Violation - Close database resources ASAP

CAST Engineering Dashboard - Violations - False Violation - Close the outermost stream ASAP

CAST Engineering Dashboard - Violations - False Violation - Control naming convention - prefix case and character set control

Relevant input

CAST Engineering Dashboard - Violations - False Violation - DOTNet - Data access must be based on Stored Procedure Calls

CAST Engineering Dashboard - Violations - False Violation - EGL - Avoid Program calls without checking the return code EGL

CAST Engineering Dashboard - Violations - False Violation - File descriptor block must be defined with 0 record

CAST Engineering Dashboard - Violations - False Violation - Mainframe - COBOL - Each opened file must be closed

CAST Engineering Dashboard - Violations - False Violation - Methods must have appropriate JavaDoc exception tags

CAST Engineering Dashboard - Violations - False Violation - Methods must have appropriate JavaDoc param tags QR

CAST Engineering Dashboard - Violations - False Violation - Methods must have appropriate JavaDoc throws tags

CAST Engineering Dashboard - Violations - False Violation - New violations showing up for unchanged code

CAST Engineering Dashboard - Violations - False Violation - Object violations from Vanilla

CAST Engineering Dashboard - Violations - False Violation - Provide a private default Constructor for utility Classes

CAST Engineering Dashboard - Violations - False Violation - Siebel - Wrong violations for Quality rules referring to the Sort or Search on non-indexed Fields

CAST Engineering Dashboard - Violations - False Violation - Standard packages are flagged as violated

CAST Engineering Dashboard - Violations - False Violation - Track Classes referencing database objects

CAST Engineering Dashboard - Violations - False Violation - Use of Style sheets

CAST Engineering Dashboard - Violations - False Violation - Wrong violations added when the 2 snapshots are not computed with same CAST version